Hi Dmitry, On Tue, 18 Jan 2022 at 19:02, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On 18/01/2022 18:47, Loic Poulain wrote: > > Add compatibility for QCM2290 display subsystem, including > > required entries in DPU hw catalog. > > > > Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxx> > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 175 ++++++++++++++++++++++++- > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + > > drivers/gpu/drm/msm/msm_drv.c | 1 + > > 4 files changed, 177 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > index ce6f32a..7fa3fc7 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > @@ -25,6 +25,8 @@ > > #define VIG_SM8250_MASK \ [...] > > +static const struct dpu_vbif_cfg qcm2290_vbif[] = { > > + { > > + .name = "vbif_0", .id = VBIF_0, > > + .base = 0, .len = 0x1040, > > + .features = BIT(DPU_VBIF_QOS_REMAP), > > + .xin_halt_timeout = 0x4000, > > + .qos_rt_tbl = { > > + .npriority_lvl = ARRAY_SIZE(sdm845_rt_pri_lvl), > > + .priority_lvl = sdm845_rt_pri_lvl, > > + }, > > + .memtype_count = 14, > > + .memtype = {3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3}, > > + }, > > +}; > > The only difference from sdm845_vbif is the lack of .qos_nrt_tbl. Is > this on purpose? Yes, I've not found any info related to non-rt for QCM2290 dpu, but I assume it would be safe to just use sdm845_vbif here, as the others. Regards, Loic