Re: [PATCH] udmabuf: put dmabuf in case of get fd failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Xianting,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.16-rc6 next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xianting-Tian/udmabuf-put-dmabuf-in-case-of-get-fd-failed/20211220-134433
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a7904a538933c525096ca2ccde1e60d0ee62c08e
config: arc-randconfig-r043-20211220 (https://download.01.org/0day-ci/archive/20211220/202112202101.tVpymGaH-lkp@xxxxxxxxx/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/322781a4da9de4a3057afd933108d23ca7f5282e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xianting-Tian/udmabuf-put-dmabuf-in-case-of-get-fd-failed/20211220-134433
        git checkout 322781a4da9de4a3057afd933108d23ca7f5282e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/dma-buf/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

   drivers/dma-buf/udmabuf.c: In function 'udmabuf_create':
>> drivers/dma-buf/udmabuf.c:292:13: error: invalid storage class for function 'udmabuf_ioctl_create'
     292 | static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
         |             ^~~~~~~~~~~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:292:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     292 | static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
         | ^~~~~~
>> drivers/dma-buf/udmabuf.c:311:13: error: invalid storage class for function 'udmabuf_ioctl_create_list'
     311 | static long udmabuf_ioctl_create_list(struct file *filp, unsigned long arg)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:332:13: error: invalid storage class for function 'udmabuf_ioctl'
     332 | static long udmabuf_ioctl(struct file *filp, unsigned int ioctl,
         |             ^~~~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:353:27: error: initializer element is not constant
     353 |         .unlocked_ioctl = udmabuf_ioctl,
         |                           ^~~~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:353:27: note: (near initialization for 'udmabuf_fops.unlocked_ioctl')
>> drivers/dma-buf/udmabuf.c:365:19: error: invalid storage class for function 'udmabuf_dev_init'
     365 | static int __init udmabuf_dev_init(void)
         |                   ^~~~~~~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:370:20: error: invalid storage class for function 'udmabuf_dev_exit'
     370 | static void __exit udmabuf_dev_exit(void)
         |                    ^~~~~~~~~~~~~~~~
   In file included from include/linux/cred.h:12,
                    from drivers/dma-buf/udmabuf.c:2:
   drivers/dma-buf/udmabuf.c:375:13: error: initializer element is not constant
     375 | module_init(udmabuf_dev_init)
         |             ^~~~~~~~~~~~~~~~
   include/linux/init.h:250:55: note: in definition of macro '____define_initcall'
     250 |                 __attribute__((__section__(__sec))) = fn;
         |                                                       ^~
   include/linux/init.h:260:9: note: in expansion of macro '__unique_initcall'
     260 |         __unique_initcall(fn, id, __sec, __initcall_id(fn))
         |         ^~~~~~~~~~~~~~~~~
   include/linux/init.h:262:35: note: in expansion of macro '___define_initcall'
     262 | #define __define_initcall(fn, id) ___define_initcall(fn, id, .initcall##id)
         |                                   ^~~~~~~~~~~~~~~~~~
   include/linux/init.h:291:41: note: in expansion of macro '__define_initcall'
     291 | #define device_initcall(fn)             __define_initcall(fn, 6)
         |                                         ^~~~~~~~~~~~~~~~~
   include/linux/init.h:296:24: note: in expansion of macro 'device_initcall'
     296 | #define __initcall(fn) device_initcall(fn)
         |                        ^~~~~~~~~~~~~~~
   include/linux/module.h:88:25: note: in expansion of macro '__initcall'
      88 | #define module_init(x)  __initcall(x);
         |                         ^~~~~~~~~~
   drivers/dma-buf/udmabuf.c:375:1: note: in expansion of macro 'module_init'
     375 | module_init(udmabuf_dev_init)
         | ^~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:376:13: error: initializer element is not constant
     376 | module_exit(udmabuf_dev_exit)
         |             ^~~~~~~~~~~~~~~~
   include/linux/init.h:299:57: note: in definition of macro '__exitcall'
     299 |         static exitcall_t __exitcall_##fn __exit_call = fn
         |                                                         ^~
   drivers/dma-buf/udmabuf.c:376:1: note: in expansion of macro 'module_exit'
     376 | module_exit(udmabuf_dev_exit)
         | ^~~~~~~~~~~
>> include/linux/init.h:299:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     299 |         static exitcall_t __exitcall_##fn __exit_call = fn
         |         ^~~~~~
   include/linux/module.h:100:25: note: in expansion of macro '__exitcall'
     100 | #define module_exit(x)  __exitcall(x);
         |                         ^~~~~~~~~~
   drivers/dma-buf/udmabuf.c:376:1: note: in expansion of macro 'module_exit'
     376 | module_exit(udmabuf_dev_exit)
         | ^~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:379:1: error: expected declaration or statement at end of input
     379 | MODULE_LICENSE("GPL v2");
         | ^~~~~~~~~~~~~~


vim +/udmabuf_ioctl_create +292 drivers/dma-buf/udmabuf.c

fbb0de795078190 Gerd Hoffmann          2018-08-27  291  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @292  static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
fbb0de795078190 Gerd Hoffmann          2018-08-27  293  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  294  	struct udmabuf_create create;
fbb0de795078190 Gerd Hoffmann          2018-08-27  295  	struct udmabuf_create_list head;
fbb0de795078190 Gerd Hoffmann          2018-08-27  296  	struct udmabuf_create_item list;
fbb0de795078190 Gerd Hoffmann          2018-08-27  297  
fbb0de795078190 Gerd Hoffmann          2018-08-27  298  	if (copy_from_user(&create, (void __user *)arg,
33f35429fc49c09 Gerd Hoffmann          2018-09-11  299  			   sizeof(create)))
fbb0de795078190 Gerd Hoffmann          2018-08-27  300  		return -EFAULT;
fbb0de795078190 Gerd Hoffmann          2018-08-27  301  
fbb0de795078190 Gerd Hoffmann          2018-08-27  302  	head.flags  = create.flags;
fbb0de795078190 Gerd Hoffmann          2018-08-27  303  	head.count  = 1;
fbb0de795078190 Gerd Hoffmann          2018-08-27  304  	list.memfd  = create.memfd;
fbb0de795078190 Gerd Hoffmann          2018-08-27  305  	list.offset = create.offset;
fbb0de795078190 Gerd Hoffmann          2018-08-27  306  	list.size   = create.size;
fbb0de795078190 Gerd Hoffmann          2018-08-27  307  
c1bbed668997268 Gurchetan Singh        2019-12-02  308  	return udmabuf_create(filp->private_data, &head, &list);
fbb0de795078190 Gerd Hoffmann          2018-08-27  309  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  310  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @311  static long udmabuf_ioctl_create_list(struct file *filp, unsigned long arg)
fbb0de795078190 Gerd Hoffmann          2018-08-27  312  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  313  	struct udmabuf_create_list head;
fbb0de795078190 Gerd Hoffmann          2018-08-27  314  	struct udmabuf_create_item *list;
fbb0de795078190 Gerd Hoffmann          2018-08-27  315  	int ret = -EINVAL;
fbb0de795078190 Gerd Hoffmann          2018-08-27  316  	u32 lsize;
fbb0de795078190 Gerd Hoffmann          2018-08-27  317  
fbb0de795078190 Gerd Hoffmann          2018-08-27  318  	if (copy_from_user(&head, (void __user *)arg, sizeof(head)))
fbb0de795078190 Gerd Hoffmann          2018-08-27  319  		return -EFAULT;
dc4716d75154b36 Gerd Hoffmann          2018-09-11  320  	if (head.count > list_limit)
fbb0de795078190 Gerd Hoffmann          2018-08-27  321  		return -EINVAL;
fbb0de795078190 Gerd Hoffmann          2018-08-27  322  	lsize = sizeof(struct udmabuf_create_item) * head.count;
fbb0de795078190 Gerd Hoffmann          2018-08-27  323  	list = memdup_user((void __user *)(arg + sizeof(head)), lsize);
fbb0de795078190 Gerd Hoffmann          2018-08-27  324  	if (IS_ERR(list))
fbb0de795078190 Gerd Hoffmann          2018-08-27  325  		return PTR_ERR(list);
fbb0de795078190 Gerd Hoffmann          2018-08-27  326  
c1bbed668997268 Gurchetan Singh        2019-12-02  327  	ret = udmabuf_create(filp->private_data, &head, list);
fbb0de795078190 Gerd Hoffmann          2018-08-27  328  	kfree(list);
fbb0de795078190 Gerd Hoffmann          2018-08-27  329  	return ret;
fbb0de795078190 Gerd Hoffmann          2018-08-27  330  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  331  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @332  static long udmabuf_ioctl(struct file *filp, unsigned int ioctl,
fbb0de795078190 Gerd Hoffmann          2018-08-27  333  			  unsigned long arg)
fbb0de795078190 Gerd Hoffmann          2018-08-27  334  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  335  	long ret;
fbb0de795078190 Gerd Hoffmann          2018-08-27  336  
fbb0de795078190 Gerd Hoffmann          2018-08-27  337  	switch (ioctl) {
fbb0de795078190 Gerd Hoffmann          2018-08-27  338  	case UDMABUF_CREATE:
fbb0de795078190 Gerd Hoffmann          2018-08-27  339  		ret = udmabuf_ioctl_create(filp, arg);
fbb0de795078190 Gerd Hoffmann          2018-08-27  340  		break;
fbb0de795078190 Gerd Hoffmann          2018-08-27  341  	case UDMABUF_CREATE_LIST:
fbb0de795078190 Gerd Hoffmann          2018-08-27  342  		ret = udmabuf_ioctl_create_list(filp, arg);
fbb0de795078190 Gerd Hoffmann          2018-08-27  343  		break;
fbb0de795078190 Gerd Hoffmann          2018-08-27  344  	default:
52499d9cdd88784 Gerd Hoffmann          2018-09-11  345  		ret = -ENOTTY;
fbb0de795078190 Gerd Hoffmann          2018-08-27  346  		break;
fbb0de795078190 Gerd Hoffmann          2018-08-27  347  	}
fbb0de795078190 Gerd Hoffmann          2018-08-27  348  	return ret;
fbb0de795078190 Gerd Hoffmann          2018-08-27  349  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  350  
fbb0de795078190 Gerd Hoffmann          2018-08-27  351  static const struct file_operations udmabuf_fops = {
fbb0de795078190 Gerd Hoffmann          2018-08-27  352  	.owner		= THIS_MODULE,
fbb0de795078190 Gerd Hoffmann          2018-08-27 @353  	.unlocked_ioctl = udmabuf_ioctl,
d4a197f4047e01d Kristian H. Kristensen 2020-09-03  354  #ifdef CONFIG_COMPAT
d4a197f4047e01d Kristian H. Kristensen 2020-09-03  355  	.compat_ioctl   = udmabuf_ioctl,
d4a197f4047e01d Kristian H. Kristensen 2020-09-03  356  #endif
fbb0de795078190 Gerd Hoffmann          2018-08-27  357  };
fbb0de795078190 Gerd Hoffmann          2018-08-27  358  
fbb0de795078190 Gerd Hoffmann          2018-08-27  359  static struct miscdevice udmabuf_misc = {
fbb0de795078190 Gerd Hoffmann          2018-08-27  360  	.minor          = MISC_DYNAMIC_MINOR,
fbb0de795078190 Gerd Hoffmann          2018-08-27  361  	.name           = "udmabuf",
fbb0de795078190 Gerd Hoffmann          2018-08-27  362  	.fops           = &udmabuf_fops,
fbb0de795078190 Gerd Hoffmann          2018-08-27  363  };
fbb0de795078190 Gerd Hoffmann          2018-08-27  364  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @365  static int __init udmabuf_dev_init(void)
fbb0de795078190 Gerd Hoffmann          2018-08-27  366  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  367  	return misc_register(&udmabuf_misc);
fbb0de795078190 Gerd Hoffmann          2018-08-27  368  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  369  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @370  static void __exit udmabuf_dev_exit(void)
fbb0de795078190 Gerd Hoffmann          2018-08-27  371  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  372  	misc_deregister(&udmabuf_misc);
fbb0de795078190 Gerd Hoffmann          2018-08-27  373  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  374  
fbb0de795078190 Gerd Hoffmann          2018-08-27  375  module_init(udmabuf_dev_init)
fbb0de795078190 Gerd Hoffmann          2018-08-27  376  module_exit(udmabuf_dev_exit)
fbb0de795078190 Gerd Hoffmann          2018-08-27  377  
fbb0de795078190 Gerd Hoffmann          2018-08-27  378  MODULE_AUTHOR("Gerd Hoffmann <kraxel@xxxxxxxxxx>");
fbb0de795078190 Gerd Hoffmann          2018-08-27 @379  MODULE_LICENSE("GPL v2");

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux