Hi Marek, On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: > > Hi Jagan, > > On 13.12.2021 13:08, Jagan Teki wrote: > > On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski > > <m.szyprowski@xxxxxxxxxxx> wrote: > >> On 12.12.2021 19:14, Jagan Teki wrote: > >>> Updated series about drm bridge conversion of exynos dsi. > >>> > >>> Patch 1: panel checker > >>> > >>> Patch 2: panel_bridge API > >>> > >>> Patch 3: Bridge conversion > >>> > >>> Patch 4: pree_enable, post_disable > >>> > >>> Patch 5: Atomic functions > >>> > >>> Patch 6: atomic_set > >>> > >>> Patch 7: DSI init in enable > >>> > >>> [1] https://patchwork.kernel.org/project/dri-devel/cover/20211210191922.2367979-1-jagan@xxxxxxxxxxxxxxxxxxxx/ > >>> > >>> Any inputs? > >> I've checked this patchset on Exynos based Trats2 board (the one with > >> simplest display pipeline: Exynos FIMD -> Exynos DSI -> s6e8aa0 DSI > >> panel). DRM stops working after the 2nd patch ("[PATCH v3 2/7] drm: > >> exynos: dsi: Use drm panel_bridge API"): > >> > >> # dmesg | grep drm > >> [ 2.511893] [drm] Exynos DRM: using 11c00000.fimd device for DMA > >> mapping operations > >> [ 2.518653] exynos-drm exynos-drm: bound 11c00000.fimd (ops > >> fimd_component_ops) > >> [ 2.535699] exynos-drm exynos-drm: bound 11c80000.dsi (ops > >> exynos_dsi_component_ops) > >> [ 2.543912] exynos-drm exynos-drm: [drm] Cannot find any crtc or sizes > >> [ 2.556107] [drm] Initialized exynos 1.1.0 20180330 for exynos-drm on > >> minor 0 > >> [ 2.573212] exynos-dsi 11c80000.dsi: [drm:exynos_dsi_host_attach] > >> *ERROR* failed to find the bridge: -19 > > Look like you have missed to apply the Child lookup patch. is it so? > > > > Let me send it, I will CC you as well. And I will also send tc358764 > > panel_bridge conversion. > > The above log is from Trats2 board, which uses only the s6e8aa0 DSI > panel. I've also checked the Arndale board, which has tc358764 bridge > and it also doesn't work. Which patches I have to apply for the tests? [PATCH v2] drm: of: Lookup if child node has panel or bridge [PATCH] drm: bridge: tc358764: Use drm panel_bridge API Thanks, Jagan.