Dear Jagan, On 12.12.2021 19:14, Jagan Teki wrote: > Updated series about drm bridge conversion of exynos dsi. > > Patch 1: panel checker > > Patch 2: panel_bridge API > > Patch 3: Bridge conversion > > Patch 4: pree_enable, post_disable > > Patch 5: Atomic functions > > Patch 6: atomic_set > > Patch 7: DSI init in enable > > [1] https://patchwork.kernel.org/project/dri-devel/cover/20211210191922.2367979-1-jagan@xxxxxxxxxxxxxxxxxxxx/ > > Any inputs? I've checked this patchset on Exynos based Trats2 board (the one with simplest display pipeline: Exynos FIMD -> Exynos DSI -> s6e8aa0 DSI panel). DRM stops working after the 2nd patch ("[PATCH v3 2/7] drm: exynos: dsi: Use drm panel_bridge API"): # dmesg | grep drm [ 2.511893] [drm] Exynos DRM: using 11c00000.fimd device for DMA mapping operations [ 2.518653] exynos-drm exynos-drm: bound 11c00000.fimd (ops fimd_component_ops) [ 2.535699] exynos-drm exynos-drm: bound 11c80000.dsi (ops exynos_dsi_component_ops) [ 2.543912] exynos-drm exynos-drm: [drm] Cannot find any crtc or sizes [ 2.556107] [drm] Initialized exynos 1.1.0 20180330 for exynos-drm on minor 0 [ 2.573212] exynos-dsi 11c80000.dsi: [drm:exynos_dsi_host_attach] *ERROR* failed to find the bridge: -19 [ 2.653553] [drm] Initialized lima 1.1.0 20191231 for 13000000.gpu on minor 1 # ./modetest -c -Mexynos Connectors: id encoder status name size (mm) modes encoders Applying the whole patchset doesn't fix anything. > Jagan. > > Jagan Teki (7): > drm: exynos: dsi: Check panel for panel helpers > drm: exynos: dsi: Use drm panel_bridge API > drm: exynos: dsi: Convert to bridge driver > drm: exynos: dsi: Separate pre_enable, post_disable code > drm: exynos: dsi: Switch to atomic funcs > drm: exynos: dsi: Get the mode from bridge > drm: exynos: dsi: Move DSI init in bridge enable > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 240 ++++++++---------------- > 1 file changed, 75 insertions(+), 165 deletions(-) > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
