Re: [Nouveau] Regression in 5.15 in nouveau

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 07.12.21 um 21:45 schrieb Dan Moulding:
There is a pretty obvious typo in there:

--- a/drivers/gpu/drm/nouveau/nouveau_fence.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
@@ -359,7 +359,7 @@ nouveau_fence_sync(struct nouveau_bo *nvbo, struct
nouveau_channel *chan, bool e
                  fobj = dma_resv_shared_list(resv);
          }

-       for (i = 0; (i < fobj ? fobj->shared_count : 0) && !ret; ++i) {
+       for (i = 0; i < (fobj ? fobj->shared_count : 0) && !ret; ++i) {
                  struct nouveau_channel *prev = NULL;
                  bool must_wait = true;


With that it works and I don't see the flickering in a short test. I
will do more testing, but maybe Dan can test, too.

Cheers,
Stefan
After fixing the typo the patch is working for me, also. dmesg is also
clean. I will continue running the patched kernel. If I see any
issues, I will report back here.

Thanks for fixing that stupid typo. I've just send out an updated version to the mailing list with everybody in CC.

Please review and/or comment further.

Regards,
Christian.


Cheers,

-- Dan




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux