On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote: > > It's perfectly valid to dereference the pointer in atomic_enable, and > > that patch would consume memory for no particular reason. > > Again, I'm not pointing any mistake in dereference and certainly not > understand about what memory consumption issue here. You add a struct drm_display_mode field to struct sun6i_dsi. It increases the size of struct sun6i_dsi of sizeof(struct drm_display_mode). > I'm doing it here since I'm doing it via mode_set in other drivers. No > problem for me either way. But *why* are you doing so? There might be a valid reason in other drivers, but there's none here (that you mentioned at least). Maxime
