Hi Oleksij,
On Mon, Oct 11, 2021 at 11:01:48AM +0200, Oleksij Rempel wrote:
> On Sat, Oct 09, 2021 at 05:12:44PM +0200, Sam Ravnborg wrote:
> > Hi Oleksij, Robin,
> >
> > On Thu, Sep 30, 2021 at 12:05:00PM +0200, Oleksij Rempel wrote:
> > > Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7"
> > > WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit.
> > >
> > > Co-Developed-by: Robin van der Gracht <robin@xxxxxxxxxxx>
> > > Signed-off-by: Robin van der Gracht <robin@xxxxxxxxxxx>
> > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> > > ---
> > > drivers/gpu/drm/panel/panel-simple.c | 16 ++++++++++++++++
> > > 1 file changed, 16 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > index 9b6c4e6c38a1..a03b60f6fa99 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -2524,6 +2524,19 @@ static const struct panel_desc innolux_g070y2_l01 = {
> > > .connector_type = DRM_MODE_CONNECTOR_LVDS,
> > > };
> > >
> > > +static const struct panel_desc innolux_g070y2_t02 = {
> > > + .modes = &innolux_at070tn92_mode,
> >
> > It is suprising to see that the innolux_g070y2_t02 uses the mode
> > innolux_at070tn92_mode.
> > Is it on purpose?
>
> yes.
>
> > If yes then I would expect the changelog to say so.
> >
> > In most (all?) other cases the panel provide their own mode.
>
> It works with same timing values. What is the preferred way, add own
> mode or extend the changelog?
Both works for me, but I would duplicate the timings.
Only because I do not trust anyone that comes later to see that the
timings are used twice.
Sam
