Re: [PATCH v5 2/2] drm/bridge: lvds-codec: Add support for LVDS data mapping select

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/10/21 2:27 PM, Sam Ravnborg wrote:

Hi,

[...]

+		if (!bus_node) {
+			dev_dbg(dev, "bus DT node not found\n");
+			return -ENXIO;
+		}
+
+		ret = of_property_read_string(bus_node, "data-mapping",
+					      &mapping);
+		of_node_put(bus_node);
+		if (ret < 0) {
+			dev_err(dev, "missing 'data-mapping' DT property\n");
+		} else {

It would be nice with a helper for the below code if we need this a third
time.

Where would you store it ?
drm_connector.c seems to be a good place.
Or maybe a static inline in drm_connector.h.

Sorry, this patch has been dragging on for over half a year, another patch which depends on this has been dragging on for over a year, so I don't feel particularly motivated to prolong that further by starting a subsystem patch discussion here now. If someone wants to make this code more generic, that can surely be a subsequent patch?



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux