Hi Am 08.07.21 um 15:31 schrieb Martin Blumenstingl:
Hi Thomas, On Tue, Jul 6, 2021 at 9:45 AM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>Tested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> and also (although I am no drm subsystem expert): Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
Oh, just when I committed the patch. But thanks for your reply.
[...]- ret = drm_irq_install(drm, priv->vsync_irq); + ret = request_irq(priv->vsync_irq, meson_irq, 0, drm->driver->name, drm);I'd like to use dev_name(dev) instead of drm->driver->name in the future as that'll make it much easier to identify the corresponding IRQ in /proc/interrupts for example your patch makes this possible - thanks for this!
I also thought about this, but every driver in DRM and apparently most drivers in general pass the driver's name here. I think the change would make a lot of sense, but it's probably worth a kernel-wide effort.
Best regards Thomas
Best regards, Martin
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
