Hi Thomas, On Tue, Jul 6, 2021 at 9:45 AM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > don't benefit from using it. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> Tested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> and also (although I am no drm subsystem expert): Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> [...] > - ret = drm_irq_install(drm, priv->vsync_irq); > + ret = request_irq(priv->vsync_irq, meson_irq, 0, drm->driver->name, drm); I'd like to use dev_name(dev) instead of drm->driver->name in the future as that'll make it much easier to identify the corresponding IRQ in /proc/interrupts for example your patch makes this possible - thanks for this! Best regards, Martin