OK, I'll revise it and submit it again
George.
From: "Christian König <ckoenig.leichtzumerken@xxxxxxxxx>"
To: "huqiqiao <huqiqiao@xxxxxxxxxxxxx>","airlied <airlied@xxxxxxxx>","daniel <daniel@xxxxxxxx>"
CC: "dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>","amd-gfx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>","linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>"
Sent: 2021-06-24 21:14
Subject: Re: [PATCH] drm/amdgpu:use kvcalloc instead of kvmalloc_array
Am 23.06.21 um 11:12 schrieb huqiqiao:
> kvmalloc_array + __GFP_ZERO is the same with kvcalloc.
>
> Signed-off-by: huqiqiao <huqiqiao@xxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 9acee4a5b2ba..50edc73525b0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -908,9 +908,8 @@ static int amdgpu_vm_alloc_pts(struct amdgpu_device *adev,
> unsigned num_entries;
>
> num_entries = amdgpu_vm_num_entries(adev, cursor->level);
> - entry->entries = kvmalloc_array(num_entries,
> - sizeof(*entry->entries),
> - GFP_KERNEL | __GFP_ZERO);
> + entry->entries = kvcalloc(num_entries,
> + sizeof(*entry->entries), GFP_KERNEL);
Sounds like a good idea in general, but the indentation on the second
line seems to be of.
Christian.
> if (!entry->entries)
> return -ENOMEM;
> }
