Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>
Will go ahead and push this to drm-misc-next-fixes, thanks
On Wed, 2021-06-16 at 12:44 -0700, José Roberto de Souza wrote:
> Commit 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by
> ports in stale topology") added to calls to drm_dbg_kms() but it
> missed the first parameter, the drm device breaking the build.
>
> Fixes: 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by ports in
> stale topology")
> Cc: Wayne Lin <Wayne.Lin@xxxxxxx>
> Cc: Lyude Paul <lyude@xxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 9ac148efd9e43..ad0795afc21cf 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -3389,7 +3389,9 @@ int drm_dp_update_payload_part1(struct
> drm_dp_mst_topology_mgr *mgr)
> mutex_unlock(&mgr->lock);
>
> if (skip) {
> - drm_dbg_kms("Virtual channel %d is not in
> current topology\n", i);
> + drm_dbg_kms(mgr->dev,
> + "Virtual channel %d is not in
> current topology\n",
> + i);
> continue;
> }
> /* Validated ports don't matter if we're releasing
> @@ -3404,7 +3406,8 @@ int drm_dp_update_payload_part1(struct
> drm_dp_mst_topology_mgr *mgr)
> payload->start_slot =
> req_payload.start_slot;
> continue;
> } else {
> - drm_dbg_kms("Fail:set
> payload to invalid sink");
> + drm_dbg_kms(mgr->dev,
> + "Fail:set
> payload to invalid sink");
> mutex_unlock(&mgr-
> >payload_lock);
> return -EINVAL;
> }
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
