On Fri, May 28, 2021 at 07:51:52PM -0400, Alyssa Rosenzweig wrote:
> The hang_limit is the threshold after which the kernel no longer
> attempts to schedule a job. Its documentation stated the opposite due to
> a typo. Correct the wording to indicate the actual purpose of the field.
>
> Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@xxxxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
Not a drm/scheduler expert myself, but makes more sense than what's there.
Thanks for your patch, pushed to drm-misc-next.
-Daniel
> ---
> include/drm/gpu_scheduler.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index 10225a0a3..d18af49fd 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -275,7 +275,7 @@ struct drm_sched_backend_ops {
> * @pending_list: the list of jobs which are currently in the job queue.
> * @job_list_lock: lock to protect the pending_list.
> * @hang_limit: once the hangs by a job crosses this limit then it is marked
> - * guilty and it will be considered for scheduling further.
> + * guilty and it will no longer be considered for scheduling.
> * @score: score to help loadbalancer pick a idle sched
> * @_score: score used when the driver doesn't provide one
> * @ready: marks if the underlying HW is ready to work
> --
> 2.30.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
