Hi Jagan, Thank you for the patch. On Mon, Mar 22, 2021 at 07:31:49PM +0530, Jagan Teki wrote: > Replace of_drm_find_panel with drm_of_find_panel_or_bridge > for finding panel, this indeed help to find the bridge if > bridge support added. > > Added NULL in bridge argument, same will replace with bridge > parameter once bridge supported. > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> Looks good, there should be no functional change. Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Changes for v4, v3: > - none > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index 4f5efcace68e..2e9e7b2d4145 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -21,6 +21,7 @@ > > #include <drm/drm_atomic_helper.h> > #include <drm/drm_mipi_dsi.h> > +#include <drm/drm_of.h> > #include <drm/drm_panel.h> > #include <drm/drm_print.h> > #include <drm/drm_probe_helper.h> > @@ -963,10 +964,14 @@ static int sun6i_dsi_attach(struct mipi_dsi_host *host, > struct mipi_dsi_device *device) > { > struct sun6i_dsi *dsi = host_to_sun6i_dsi(host); > - struct drm_panel *panel = of_drm_find_panel(device->dev.of_node); > + struct drm_panel *panel; > + int ret; > + > + ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 0, 0, > + &panel, NULL); > + if (ret) > + return ret; > > - if (IS_ERR(panel)) > - return PTR_ERR(panel); > if (!dsi->drm || !dsi->drm->registered) > return -EPROBE_DEFER; > -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel