Hi Kieran, On Mon, Mar 01, 2021 at 11:52:26AM +0000, Kieran Bingham wrote: > On 01/03/2021 10:30, Geert Uytterhoeven wrote: > > On Thu, Jan 14, 2021 at 11:00 AM Geert Uytterhoeven wrote: > >> On Wed, Jan 13, 2021 at 6:02 PM Kieran Bingham wrote: > >>> The encoder allocation was converted to a DRM managed resource at the > >>> same time as the addition of a new helper drmm_encoder_alloc() which > >>> simplifies the same process. > >>> > >>> Convert the custom drm managed resource allocation of the encoder > >>> with the helper to simplify the implementation, and prevent hitting a > >>> WARN_ON() due to the handling the drm_encoder_init() call directly > >>> without registering a .destroy() function op. > >>> > >>> Fixes: f5f16725edbc ("drm: rcar-du: Use DRM-managed allocation for encoders") > >>> Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > >>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > >> > >> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > >> As in "the WARNING from drm_encoder_init() is gone". > > > > JFYI, the WARNING is now in v5.12-rc1, the fix isn't. > > Does this patch go through you to get into the DRM tree? Or do I need to > re-send it to someone else? I can send a pull request with this for the -fixes branch, but as there's a single patch, maybe David or Daniel could pick it up ? -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel