On Thu, Jan 14, 2021 at 11:00 AM Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Wed, Jan 13, 2021 at 6:02 PM Kieran Bingham
> <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote:
> > The encoder allocation was converted to a DRM managed resource at the
> > same time as the addition of a new helper drmm_encoder_alloc() which
> > simplifies the same process.
> >
> > Convert the custom drm managed resource allocation of the encoder
> > with the helper to simplify the implementation, and prevent hitting a
> > WARN_ON() due to the handling the drm_encoder_init() call directly
> > without registering a .destroy() function op.
> >
> > Fixes: f5f16725edbc ("drm: rcar-du: Use DRM-managed allocation for encoders")
> > Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>
> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> As in "the WARNING from drm_encoder_init() is gone".
JFYI, the WARNING is now in v5.12-rc1, the fix isn't.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
