On Fri, Feb 05, 2021 at 10:43:14AM +0100, Robert Foss wrote: > On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat <drinkcat@xxxxxxxxxxxx> wrote: > > > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@xxxxxxxxxxx> wrote: > > > > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@xxxxxxxxxx> wrote: > > > >> Hi Xin, > > > >> > > > >> Thanks for the patch. > > > >> > > > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@xxxxxxxxxxxxxxxx> wrote: > > > >>> Enable DSI EOTP feature for fixing some panel screen constance > > > >>> shift issue. > > > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > > Does "constance shift" have a typo? Should it be "constant shift"? > > With that sorted out feel free to add my r-b. > Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx> Hi Robert Foss, thanks, I'll correct it. Thanks, Xin > > > > >> I don't think I quite understand how removing the > > > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > > > >> you extrapolate on this in the commit message? > > > > That confused me as well, but it turns out that's how the flag is defined: > > > > ``` > > > > /* disable EoT packets in HS mode */ > > > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > > > ``` > > > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > > > > > > > Yes that would be good, many of these flags were just copy pasted from > > > some hw datasheet, without good analysis how to adapt them to the framework. > > > > I'll look into it (but that shouldn't block this patch). > > Thanks for clearing this up Nicolas & Andrzej! _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
