On Wednesday, February 3rd, 2021 at 11:08 AM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: > On Wed, 3 Feb 2021 at 09:27, Simon Ser <contact@xxxxxxxxxxx> wrote: > > > > On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov emil.l.velikov@xxxxxxxxx wrote: > > > > > As summed in the commit message the burden is only applicable when all > > > of the following are set: > > > - non-linux > > > - force DRM_FOURCC_STANDALONE > > > - c99 -pedantic > > > > Oh, and FWIW, this is not a theoretical situation at all. All of these > > conditions happen to be true on my compositor. It has FreeBSD CI, > > -Werror, and will use DRM_FOURCC_STANDALONE when available. > > There are ways to disable [1] or silence [2] this - are you > intentionally ignoring them? We have a policy against pragma. However we already use -std=c11, so in fact wouldn't be affected by this change. > Or the goal here is to 'fix' the kernel for a very uncommon non-linux use-case? If the kernel doesn't care about non-Linux, why is there an #ifdef __linux__ in the first place? > [1] pragma GCC diagnostic warning "-Wpedantic" > [2] pragma GCC diagnostic ignored or -std=c11 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
