On Tue, Jan 05, 2021 at 05:17:01PM +0300, Dan Carpenter wrote: > On Thu, Dec 31, 2020 at 10:22:36AM +0800, Xin Ji wrote: > > static int anx7625_read_ctrl_status_p0(struct anx7625_data *ctx) > > { > > return anx7625_reg_read(ctx, ctx->i2c.rx_p0_client, AP_AUX_CTRL_STATUS); > > @@ -189,10 +203,64 @@ static int wait_aux_op_finish(struct anx7625_data *ctx) > > AP_AUX_CTRL_STATUS); > > if (val < 0 || (val & 0x0F)) { > > DRM_DEV_ERROR(dev, "aux status %02x\n", val); > > - val = -EIO; > > + return -EIO; > > } > > > > - return val; > > + return 0; > > This s/val/0/ change seems like a bug fix. Could you please send that > as a separate patch at the start of the patch set? Hi Dan Carpenter, OK, I'll send this as a separate patch. Thanks, Xin > > > +} > > regards, > dan carpenter _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel