Hi Thomas.
On Tue, Dec 01, 2020 at 03:21:59PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
> > Fix warnings:
> > - drop kernel-doc for the two debug functions to avoid the warnings
> > - delete unused code
> >
> > v2:
> > - Updated subject (Lee)
> >
> > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > Cc: Thomas Zimemrmann <tzimmermann@xxxxxxx>
> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > Cc: "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Cc: Saeed Mirzamohammadi <saeed.mirzamohammadi@xxxxxxxxxx>
> > Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
> > Cc: Mike Rapoport <rppt@xxxxxxxxxx>
> > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> > drivers/video/fbdev/cirrusfb.c | 20 +++++++++-----------
> > 1 file changed, 9 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c
> > index e9027172c0f5..93802abbbc72 100644
> > --- a/drivers/video/fbdev/cirrusfb.c
> > +++ b/drivers/video/fbdev/cirrusfb.c
> > @@ -2463,8 +2463,6 @@ static void AttrOn(const struct cirrusfb_info *cinfo)
> > */
> > static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
> > {
> > - unsigned char dummy;
> > -
> > if (is_laguna(cinfo))
> > return;
> > if (cinfo->btype == BT_PICASSO) {
> > @@ -2473,18 +2471,18 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
> > WGen(cinfo, VGA_PEL_MSK, 0x00);
> > udelay(200);
> > /* next read dummy from pixel address (3c8) */
> > - dummy = RGen(cinfo, VGA_PEL_IW);
> > + RGen(cinfo, VGA_PEL_IW);
>
> I hope these kinds of changes do not turn into an endless stream of warnings
> from static ananlysis. I git an email with that today about such a call.
Got the same mail, will type a patch for it.
>
> Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
This and the other acked patches are now applied to drm-misc-next.
Building for a few more architectures turned up new warnings, so I will
prepare a new set of patches with comments addressed.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
