On Mon, 30 Nov 2020, Sam Ravnborg wrote: > On Mon, Nov 30, 2020 at 01:14:52PM +0100, Thomas Zimmermann wrote: > > > > > > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > > > Fix W=1 warnings: > > > - Fix kernel-doc > > > - Drop unused variables/code > > > > > > v2: > > > - Updated subject (Lee) > > > > > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > Cc: Antonino Daplas <adaplas@xxxxxxxxx> > > > Cc: linux-fbdev@xxxxxxxxxxxxxxx > > > Cc: Lee Jones <lee.jones@xxxxxxxxxx> > > > --- > > > drivers/video/fbdev/riva/fbdev.c | 9 ++++----- > > > drivers/video/fbdev/riva/riva_hw.c | 28 ++++++++-------------------- > > > 2 files changed, 12 insertions(+), 25 deletions(-) > > > > > > diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c > > > index ce55b9d2e862..55554b0433cb 100644 > > > --- a/drivers/video/fbdev/riva/fbdev.c > > > +++ b/drivers/video/fbdev/riva/fbdev.c > > > @@ -464,7 +464,7 @@ static inline void reverse_order(u32 *l) > > > /** > > > * rivafb_load_cursor_image - load cursor image to hardware > > > - * @data: address to monochrome bitmap (1 = foreground color, 0 = background) > > > + * @data8: address to monochrome bitmap (1 = foreground color, 0 = background) > > > * @par: pointer to private data > > > * @w: width of cursor image in pixels > > > * @h: height of cursor image in scanlines > > > @@ -843,9 +843,9 @@ static void riva_update_var(struct fb_var_screeninfo *var, > > > /** > > > * rivafb_do_maximize - > > > * @info: pointer to fb_info object containing info for current riva board > > > - * @var: > > > - * @nom: > > > - * @den: > > > + * @var: standard kernel fb changeable data > > > + * @nom: nom > > > + * @den: den Cop-out! Do what I do and make something up (joke)! :'D > > Well, it fixes the warning ;) > > Yeah, I could not dig up anything useful to say here. > Was tempted to just drop all the kernel-doc syntax but that > was a larger change. Did you trace it from it's origin down to it's final use? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
