Re: [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem

[Thomas Zimmermann <tzimmermann@xxxxxxx>]

Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
> Fix W=1 warnings by removing unused code
>
> v2:
>    - Updated subject (Lee)
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Evgeny Novikov <novikov@xxxxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
> Cc: Mike Rapoport <rppt@xxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>

Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

> ---
>   drivers/video/fbdev/neofb.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/neofb.c b/drivers/video/fbdev/neofb.c
> index 09a20d4ab35f..c0f4f402da3f 100644
> --- a/drivers/video/fbdev/neofb.c
> +++ b/drivers/video/fbdev/neofb.c
> @@ -1843,7 +1843,6 @@ static int neo_init_hw(struct fb_info *info)
>   	struct neofb_par *par = info->par;
>   	int videoRam = 896;
>   	int maxClock = 65000;
> -	int CursorMem = 1024;
>   	int CursorOff = 0x100;
>   
>   	DBG("neo_init_hw");
> @@ -1895,19 +1894,16 @@ static int neo_init_hw(struct fb_info *info)
>   	case FB_ACCEL_NEOMAGIC_NM2070:
>   	case FB_ACCEL_NEOMAGIC_NM2090:
>   	case FB_ACCEL_NEOMAGIC_NM2093:
> -		CursorMem = 2048;
>   		CursorOff = 0x100;
>   		break;
>   	case FB_ACCEL_NEOMAGIC_NM2097:
>   	case FB_ACCEL_NEOMAGIC_NM2160:
> -		CursorMem = 1024;
>   		CursorOff = 0x100;
>   		break;
>   	case FB_ACCEL_NEOMAGIC_NM2200:
>   	case FB_ACCEL_NEOMAGIC_NM2230:
>   	case FB_ACCEL_NEOMAGIC_NM2360:
>   	case FB_ACCEL_NEOMAGIC_NM2380:
> -		CursorMem = 1024;
>   		CursorOff = 0x1000;
>   
>   		par->neo2200 = (Neo2200 __iomem *) par->mmio_vbase;

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel