Re: [PATCH v2 28/28] video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
Fix following W=1 warnings:
- Fix set but not nused variables which was used only for logging.

s/nused/used

s/which was/that were

Otherwise

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

   Fixed by introducing no_printk() to trick compiler to think variables
   are used
- Fix kernel-doc warning by deleting an empty comment line

v2:
   - Subject updated (Lee)

Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Cc: Kristoffer Ericson <kristoffer.ericson@xxxxxxxxx>
Cc: Lee Jones <lee.jones@xxxxxxxxxx>
---
  drivers/video/fbdev/s1d13xxxfb.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
index 4541afcf9386..d1b5f965bc96 100644
--- a/drivers/video/fbdev/s1d13xxxfb.c
+++ b/drivers/video/fbdev/s1d13xxxfb.c
@@ -45,7 +45,7 @@
  #if 0
  #define dbg(fmt, args...) do { printk(KERN_INFO fmt, ## args); } while(0)
  #else
-#define dbg(fmt, args...) do { } while (0)
+#define dbg(fmt, args...) do { no_printk(KERN_INFO fmt, ## args); } while (0)
  #endif
/*
@@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area)
  }
/**
- *
   *	s1d13xxxfb_bitblt_solidfill - accelerated solidfill function
   *	@info : framebuffer structure
   *	@rect : fb_fillrect structure


--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux