Am 27.11.20 um 15:46 schrieb Daniel Vetter:
On Fri, Nov 27, 2020 at 3:10 PM Christian König
<ckoenig.leichtzumerken@xxxxxxxxx> wrote:
Am 27.11.20 um 09:31 schrieb Dave Airlie:
Oops sorry for delay LGTM
Reviewed-by: Dave Airlie <airlied@xxxxxxxxxx>
Thanks.
On Fri, 27 Nov 2020 at 02:34, Daniel Vetter <daniel@xxxxxxxx> wrote:
On Wed, Nov 25, 2020 at 3:34 PM Christian König
<ckoenig.leichtzumerken@xxxxxxxxx> wrote:
Reorder the code to fix checking if blitting is available.
Might be good to explain why blitting might not be available, e.g.
suspend/resume and or chip death and stuff like that.
Signed-off-by: Christian König <christian.koenig@xxxxxxx>
Needs Fixes: 28a68f828266 ("drm/radeon/ttm: use multihop")
Why does the subject of the patch needs to be in "()" ? I was already
wondering why dim sometimes complains about my Fixes tag.
Hm I thought that's the official style. I kinda hacked around on it
until linux-next stopped complaining about our Fixes: tags. Maybe it's
not quite accurately reflecting the current bikeshed. Iirc checkpatch
even complains when you leave out the commit before the sha1, at least
in free-form text in the commit message.
Well "git log -1 --oneline 28a68f828266" gives me:
28a68f828266 drm/radeon/ttm: use multihop
Which is what I would naturally expect here, but no idea what the
official format should be.
Christian.
-Daniel
Btw
$ dim fixes [sha1]
generates that for you plus nice cc list of offenders. With the Fixes
line added:
Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
Thanks,
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
