Re: [PATCH] drm/vram: fix incorrect flag variable usage.

[Thomas Zimmermann <tzimmermann@xxxxxxx>]

Hi

we already have

  b8f8dbf64958 ("drm/vram-helper: Fix use of top-down placement")

in drm-tip. And it does exactly the same. I guess it went in through 
drm-misc-next instead of -misc-fixes.

Am 19.11.20 um 02:14 schrieb Dave Airlie:
> From: Dave Airlie <airlied@xxxxxxxxxx>
>
> In 7053e0eab473119503f6565b4e398f9a73122481
> drm/vram-helper: stop using TTM placement flags

The subject line might be a bit misleading.

In any case

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Best regards
Thomas

> it appears the flags got mixed up.
>
> This should fix a regression on ast
> [   64.782340] WARNING: CPU: 51 PID: 1964 at drivers/gpu/drm/drm_gem_vram_helper.c:284 drm_gem_vram_offset+0x35/0x40 [drm_vram_helper]
> [   64.782411] CPU: 51 PID: 1964 Comm: Xorg Not tainted 5.10.0-rc3 #12
> [   64.782413] Hardware name: To be filled.
> [   64.782419] RIP: 0010:drm_gem_vram_offset+0x35/0x40 [drm_vram_helper]
> [   64.782424] Code: 00 48 89 e5 85 c0 74 17 48 83 bf 78 01 00 00 00 74 18 48 8b 87 80 01 00 00 5d 48 c1 e0 0c c3 0f 0b 48 c7 c0 ed ff ff ff 5d c3 <0f> 0b 31 c0 5d c3 0f 1f 44 00 00 0f 1f 44 00 00 55 48 8b 87 18 06
> [   64.782427] RSP: 0018:ffffa9128909fa68 EFLAGS: 00010246
> [   64.782431] RAX: 0000000000000002 RBX: ffff95a5c25e1ec0 RCX: ffffffffc02b6600
> [   64.782433] RDX: ffff959e49824000 RSI: ffff95a5c25e0b40 RDI: ffff959e4b1c2c00
> [   64.782434] RBP: ffffa9128909fa68 R08: 0000000000000040 R09: ffff95a9c5dcb688
> [   64.782436] R10: 0000000000000000 R11: 0000000000000001 R12: ffff959e49824000
> [   64.782437] R13: 0000000000000000 R14: 0000000000000000 R15: ffff95a5c5c56f00
> [   64.782440] FS:  00007f485d466a80(0000) GS:ffff95a9afcc0000(0000) knlGS:0000000000000000
> [   64.782442] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [   64.782444] CR2: 00007f485e202000 CR3: 0000000c82a0e000 CR4: 00000000003506e0
> [   64.782446] Call Trace:
> [   64.782455]  ast_cursor_page_flip+0x22/0x100 [ast]
> [   64.782460]  ast_cursor_plane_helper_atomic_update+0x46/0x70 [ast]
> [   64.782477]  drm_atomic_helper_commit_planes+0xbd/0x220 [drm_kms_helper]
> [   64.782493]  drm_atomic_helper_commit_tail_rpm+0x3a/0x70 [drm_kms_helper]
> [   64.782507]  commit_tail+0x99/0x130 [drm_kms_helper]
> [   64.782521]  drm_atomic_helper_commit+0x123/0x150 [drm_kms_helper]
> [   64.782551]  drm_atomic_commit+0x4a/0x50 [drm]
> [   64.782565]  drm_atomic_helper_update_plane+0xe7/0x140 [drm_kms_helper]
> [   64.782592]  __setplane_atomic+0xcc/0x110 [drm]
> [   64.782619]  drm_mode_cursor_universal+0x13e/0x260 [drm]
> [   64.782647]  drm_mode_cursor_common+0xef/0x220 [drm]
> [   64.782654]  ? tomoyo_path_number_perm+0x6f/0x200
> [   64.782680]  ? drm_mode_cursor_ioctl+0x60/0x60 [drm]
> [   64.782706]  drm_mode_cursor2_ioctl+0xe/0x10 [drm]
> [   64.782727]  drm_ioctl_kernel+0xae/0xf0 [drm]
> [   64.782749]  drm_ioctl+0x241/0x3f0 [drm]
> [   64.782774]  ? drm_mode_cursor_ioctl+0x60/0x60 [drm]
> [   64.782781]  ? tomoyo_file_ioctl+0x19/0x20
> [   64.782787]  __x64_sys_ioctl+0x91/0xc0
> [   64.782792]  do_syscall_64+0x38/0x90
> [   64.782797]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>
> Cc: Wen Pu <puwen@xxxxxxxx>
> Cc: David Laight <David.Laight@xxxxxxxxxx>
> Cc: Christian König <christian.koenig@xxxxxxx>
> ---
>   drivers/gpu/drm/drm_gem_vram_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
> index 50cad0e4a92e..2896a057b771 100644
> --- a/drivers/gpu/drm/drm_gem_vram_helper.c
> +++ b/drivers/gpu/drm/drm_gem_vram_helper.c
> @@ -140,7 +140,7 @@ static void drm_gem_vram_placement(struct drm_gem_vram_object *gbo,
>   	unsigned int c = 0;
>   
>   	if (pl_flag & DRM_GEM_VRAM_PL_FLAG_TOPDOWN)
> -		pl_flag = TTM_PL_FLAG_TOPDOWN;
> +		invariant_flag = TTM_PL_FLAG_TOPDOWN;
>   
>   	gbo->placement.placement = gbo->placements;
>   	gbo->placement.busy_placement = gbo->placements;

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachment: OpenPGP_0x680DC11D530B7A23.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel