Re: [PATCH] drm/vram: fix incorrect flag variable usage.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dave,

I love your patch! Yet something to improve:

[auto build test ERROR on tegra-drm/drm/tegra/for-next]
[also build test ERROR on linus/master v5.10-rc4]
[cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip drm/drm-next next-20201118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dave-Airlie/drm-vram-fix-incorrect-flag-variable-usage/20201119-091523
base:   git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
config: riscv-randconfig-r034-20201119 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b2613fb2f0f53691dd0211895afbb9413457fca7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/34989355252d40699a479afefb95750e30b90766
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dave-Airlie/drm-vram-fix-incorrect-flag-variable-usage/20201119-091523
        git checkout 34989355252d40699a479afefb95750e30b90766
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/drm_gem_vram_helper.c:143:3: error: use of undeclared identifier 'invariant_flag'; did you mean 'invariant_flags'?
                   invariant_flag = TTM_PL_FLAG_TOPDOWN;
                   ^~~~~~~~~~~~~~
                   invariant_flags
   drivers/gpu/drm/drm_gem_vram_helper.c:138:6: note: 'invariant_flags' declared here
           u32 invariant_flags = 0;
               ^
   1 error generated.

vim +143 drivers/gpu/drm/drm_gem_vram_helper.c

   134	
   135	static void drm_gem_vram_placement(struct drm_gem_vram_object *gbo,
   136					   unsigned long pl_flag)
   137	{
   138		u32 invariant_flags = 0;
   139		unsigned int i;
   140		unsigned int c = 0;
   141	
   142		if (pl_flag & DRM_GEM_VRAM_PL_FLAG_TOPDOWN)
 > 143			invariant_flag = TTM_PL_FLAG_TOPDOWN;
   144	
   145		gbo->placement.placement = gbo->placements;
   146		gbo->placement.busy_placement = gbo->placements;
   147	
   148		if (pl_flag & DRM_GEM_VRAM_PL_FLAG_VRAM) {
   149			gbo->placements[c].mem_type = TTM_PL_VRAM;
   150			gbo->placements[c++].flags = TTM_PL_FLAG_WC |
   151						     TTM_PL_FLAG_UNCACHED |
   152						     invariant_flags;
   153		}
   154	
   155		if (pl_flag & DRM_GEM_VRAM_PL_FLAG_SYSTEM || !c) {
   156			gbo->placements[c].mem_type = TTM_PL_SYSTEM;
   157			gbo->placements[c++].flags = TTM_PL_MASK_CACHING |
   158						     invariant_flags;
   159		}
   160	
   161		gbo->placement.num_placement = c;
   162		gbo->placement.num_busy_placement = c;
   163	
   164		for (i = 0; i < c; ++i) {
   165			gbo->placements[i].fpfn = 0;
   166			gbo->placements[i].lpfn = 0;
   167		}
   168	}
   169	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux