On Thu, Sep 10, 2020 at 10:06:10PM +0800, Jason Yan wrote:
> This function always return '0' and no callers use the return value. So
> make it a void function.
>
> This eliminates the following coccicheck warning:
>
> drivers/gpu/drm/i810/i810_dma.c:860:8-11: Unneeded variable: "ret".
> Return "0" on line 885
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
Queued up for 5.10 in drm-misc-next, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/i810/i810_dma.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c
> index 303c2d483c6e..88250860f8e4 100644
> --- a/drivers/gpu/drm/i810/i810_dma.c
> +++ b/drivers/gpu/drm/i810/i810_dma.c
> @@ -853,11 +853,11 @@ static void i810_dma_quiescent(struct drm_device *dev)
> i810_wait_ring(dev, dev_priv->ring.Size - 8);
> }
>
> -static int i810_flush_queue(struct drm_device *dev)
> +static void i810_flush_queue(struct drm_device *dev)
> {
> drm_i810_private_t *dev_priv = dev->dev_private;
> struct drm_device_dma *dma = dev->dma;
> - int i, ret = 0;
> + int i;
> RING_LOCALS;
>
> i810_kernel_lost_context(dev);
> @@ -882,7 +882,7 @@ static int i810_flush_queue(struct drm_device *dev)
> DRM_DEBUG("still on client\n");
> }
>
> - return ret;
> + return;
> }
>
> /* Must be called with the lock held */
> --
> 2.25.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
