On Thu, Sep 10, 2020 at 08:33:43PM +0200, Sam Ravnborg wrote: > Hi Daniel. > > > > + } > > > + > > > + /* Initialize MIPI DSI */ > > > + ret = kmb_dsi_init(drm, adv_bridge); > > > > Split up isn't correct here, this won't compile since the dsi code isn't > > in this patch yet. So you need to have this ordered the other way round. > > I have explicit asked for a simple file split as done here > and told Anitha this was fine. > > As the kbuild/kconfig bits are the last patch then no build breakage. > The file based split was IMO fine to ease review. > > If this is not OK then blame me :-) Ah I missed that, sounds ok for me too then :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
