On Wed, 26 Aug 2020 10:15:24 +0200 Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> wrote: > Bridge drivers that implement the new model only shall return an error > from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR > flag is not set. So make sure we return an error because only the new > drm_bridge model is supported. > > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > --- > > Changes in v2: None > > drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > b/drivers/gpu/drm/bridge/parade-ps8640.c index > 13755d278db6..ce3e8b2da8c9 100644 --- > a/drivers/gpu/drm/bridge/parade-ps8640.c +++ > b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -200,6 +200,10 @@ static > int ps8640_bridge_attach(struct drm_bridge *bridge, .channel = 0, > .node = NULL, > }; > + > + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) > + return -EINVAL; > + > /* port@0 is ps8640 dsi input port */ > in_ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, -1); > if (!in_ep) Reviewed-by: Bilal Wasim <bwasim.lkml@xxxxxxxxx> Tested-by: Bilal Wasim <bwasim.lkml@xxxxxxxxx> -Bilal _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel