On 8/12/20 10:40 AM, Alyssa Rosenzweig wrote:
...and in merging my code with Alyssa's new panfrost format modifier
support, I see panfrost does the opposite of this and treats a format
modifier list of only INVALID as "don't care". I modeled the new nouveau
behavior on the Iris driver. Now I'm not sure which is correct :-(
....and neither am I. Uh-oh.
I modeled the panfrost code after v3d_resource_create_with_modifiers,
which treats INVALID as "don't care". I can confirm the panfrost code
works (in the sense that it's functional on the machines I've tested),
but I don't know if it is actually correct. I think it is, since
otherwise you end up using linear in places it's unnecessary, but I'm
not sure where this is spec'd.
It would depend on whether an app actually calls the function this way,
and whether that app was tested I suppose. If I'm interpreting the Iris
code correctly and it doesn't break anything, then I'm assuming both
implementations are equally valid in that nothing exercises this path,
but it would be good to have the intended behavior documented somewhere
so we can try to work towards consistent in case someone tries it in the
future.
My nouveau change runs afoul of assumptions in the tegra driver, but
that's easy enough to fix in lockstep if desired.
Also, heads up: I'll ping you on my format modifier cleanup MR once I've
pushed the latest version. The panfrost modifier usage was harder to
merge into the refactoring than most, so it'll be good to have your
review and if you have time, some testing. I think I landed on an
elegant solution, but open to suggestions.
Thanks,
-James
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
