Hello Rob, Thanks for the review! On Tue, 21 Jul 2020 at 09:03, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Thu, Jul 16, 2020 at 09:08:57PM +0530, Sumit Semwal wrote: > > The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 > > and 6.18 inches size. It is found in some of the Poco F1 phones. > > > > Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > > --- > > .../display/panel/tianma,nt36672a.yaml | 110 ++++++++++++++++++ > > 1 file changed, 110 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > > new file mode 100644 > > index 000000000000..3c583ca926ee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > > @@ -0,0 +1,110 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/tianma,nt36672a.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Tianma model NT36672A DSI Panel display driver > > + > > +maintainers: > > + - Sumit Semwal <sumit.semwal@xxxxxxxxxx> > > + > > +description: | > > + The nt36672a panel from Tianma is a FHD+ LCD display panel with a resolution > > + of 1080x2246. It is a video mode DSI panel. > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + const: tianma,nt36672a > > + > > + reg: > > + description: DSI virtual channel of the peripheral > > + > > + reset-gpios: > > + description: phandle of gpio for reset line - This should be 8mA, gpio > > + can be configured using mux, pinctrl, pinctrl-names (active high) > > + > > + vddio-supply: > > + description: phandle of the regulator that provides the supply voltage > > + Power IC supply > > + > > + vddpos-supply: > > + description: phandle of the positive boost supply regulator > > + > > + vddneg-supply: > > + description: phandle of the negative boost supply regulator > > + > > + pinctrl-names: > > + description: Pinctrl for panel active and suspend > > + > > + pinctrl-0: > > + description: Active pinctrls > > + > > + pinctrl-1: > > + description: Suspend pinctrls > > I think the pinctrl should go in the DSI controller node, not the > display unless it is settings for 'reset-gpios'. Yes, from the downstream code, this seems to be for reset-gpios. > > > + > > + ports: > > + type: object > > + properties: > > + port@0: > > + type: object > > + description: DSI input port driven by master DSI > > + properties: > > + reg: > > + const: 0 > > + > > + required: > > + - reg > > For a single port, you can do just 'port' (without ports node). Thanks; will update in next version. > > > + > > +required: > > + - compatible > > + - reg > > + - vddi0-supply > > + - vddpos-supply > > + - vddneg-supply > > + - reset-gpios > > + - pinctrl-names > > + - pinctrl-0 > > + - pinctrl-1 > > + - ports > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - |+ > > + #include <dt-bindings/gpio/gpio.h> > > + dsi0 { > > dsi { > > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + panel@0 { > > + compatible = "tianma,nt36672a"; > > + reg = <0>; > > + vddi0-supply = <&vreg_l14a_1p88>; > > + vddpos-supply = <&lab>; > > + vddneg-supply = <&ibb>; > > + > > + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > > + > > + pinctrl-names = "panel_active", "panel_suspend"; > > + pinctrl-0 = <&sde_dsi_active>; > > + pinctrl-1 = <&sde_dsi_suspend>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + tianma_nt36672a_in_0: endpoint { > > + remote-endpoint = <&dsi0_out>; > > + }; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > -- > > 2.27.0 > > Best, Sumit. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
