On 2020-06-24 16:04, Mark Brown wrote:
On Wed, Jun 24, 2020 at 03:25:33PM +0100, Robin Murphy wrote:
And yeah, anyone who pipes up suggesting that places where an ERR_PTR value
could be passed to probe_err() could simply refactor IS_ERR() checks with
more uses of the god-awful PTR_ERR_OR_ZERO() obfuscator gets a long stare of
disapproval...
We could also have a probe_err_ptr() or something that took an ERR_PTR()
instead if there really were an issue with explicitly doing this.
Yeah, for all my lyrical objection, a static inline <blah>_ptr_err()
helper to wrap <blah>_err() with sensible type checking might actually
be an OK compromise if people really feel strongly for having that utility.
(and then we can debate whether it should also convert NULL to -ENOMEM
and !IS_ERR to 0... :D)
Robin.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
