Hi All,
Recently I took some time to re-check error handling in drivers probe code,
and I have noticed that number of incorrect resource acquisition error handling
increased and there are no other propositions which can cure the situation.
So I have decided to resend my old proposition of probe_err helper which should
simplify resource acquisition error handling, it also extend it with adding defer
probe reason to devices_deferred debugfs property, which should improve debugging
experience for developers/testers.
In v5 I have also attached patch adding macro to replace quite frequent calls:
probe_err(dev, PTR_ERR(ptr), ...)
with
probe_err(dev, ptr, ...)
I have also added two patches showing usage and benefits of the helper.
My dirty/ad-hoc cocci scripts shows that this helper can be used in at least 2700 places
saving about 3500 lines of code.
Regards
Andrzej
Andrzej Hajda (5):
driver core: add probe_err log helper
driver core: add deferring probe reason to devices_deferred property
drivers core: allow probe_err accept integer and pointer types
drm/bridge/sii8620: fix resource acquisition error handling
drm/bridge: lvds-codec: simplify error handling code
drivers/base/base.h | 3 +++
drivers/base/core.c | 20 ++++++++++++++++++++
drivers/base/dd.c | 21 ++++++++++++++++++++-
drivers/gpu/drm/bridge/lvds-codec.c | 9 ++-------
drivers/gpu/drm/bridge/sil-sii8620.c | 18 ++++++------------
include/linux/device.h | 26 ++++++++++++++++++++++++++
6 files changed, 77 insertions(+), 20 deletions(-)
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
