On Tue, Jun 9, 2020 at 3:35 AM Colton Lewis <colton.w.lewis@xxxxxxxxxxxxxx> wrote: > > Silence documentation warnings by correcting kernel-doc comments. > > ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3388: warning: Excess function parameter 'suspend' description in 'amdgpu_device_suspend' > ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3485: warning: Excess function parameter 'resume' description in 'amdgpu_device_resume' > ./drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:418: warning: Excess function parameter 'tbo' description in 'amdgpu_vram_mgr_del' > ./drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:418: warning: Excess function parameter 'place' description in 'amdgpu_vram_mgr_del' > ./drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c:279: warning: Excess function parameter 'tbo' description in 'amdgpu_gtt_mgr_del' > ./drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c:279: warning: Excess function parameter 'place' description in 'amdgpu_gtt_mgr_del' > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:332: warning: Function parameter or member 'hdcp_workqueue' not described in 'amdgpu_display_manager' > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:332: warning: Function parameter or member 'cached_dc_state' not described in 'amdgpu_display_manager' > > Signed-off-by: Colton Lewis <colton.w.lewis@xxxxxxxxxxxxxx> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 -- > drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 -- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 ++ > 4 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index a027a8f7b281..dd7da7b4b696 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -3377,7 +3377,6 @@ void amdgpu_device_fini(struct amdgpu_device *adev) > * amdgpu_device_suspend - initiate device suspend > * > * @dev: drm dev pointer > - * @suspend: suspend state > * @fbcon : notify the fbdev of suspend > * > * Puts the hw in the suspend state (all asics). > @@ -3474,7 +3473,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool fbcon) > * amdgpu_device_resume - initiate device resume > * > * @dev: drm dev pointer > - * @resume: resume state > * @fbcon : notify the fbdev of resume > * > * Bring the hw back to operating state (all asics). > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c > index 627104401e84..bc01a06546aa 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c > @@ -268,8 +268,6 @@ static int amdgpu_gtt_mgr_new(struct ttm_mem_type_manager *man, > * amdgpu_gtt_mgr_del - free ranges > * > * @man: TTM memory type manager > - * @tbo: TTM BO we need this range for > - * @place: placement flags and restrictions > * @mem: TTM memory object > * > * Free the allocated GTT again. > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c > index d399e5893170..97ad8ffe6c6c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c > @@ -407,8 +407,6 @@ static int amdgpu_vram_mgr_new(struct ttm_mem_type_manager *man, > * amdgpu_vram_mgr_del - free ranges > * > * @man: TTM memory type manager > - * @tbo: TTM BO we need this range for > - * @place: placement flags and restrictions > * @mem: TTM memory object > * > * Free the allocated VRAM again. > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > index d61186ff411d..86c132ddc452 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > @@ -139,10 +139,12 @@ struct amdgpu_dm_backlight_caps { > * @backlight_link: Link on which to control backlight > * @backlight_caps: Capabilities of the backlight device > * @freesync_module: Module handling freesync calculations > + * @hdcp_workqueue: AMDGPU content protection queue > * @fw_dmcu: Reference to DMCU firmware > * @dmcu_fw_version: Version of the DMCU firmware > * @soc_bounding_box: SOC bounding box values provided by gpu_info FW > * @cached_state: Caches device atomic state for suspend/resume > + * @cached_dc_state: Cached state of content streams > * @compressor: Frame buffer compression buffer. See &struct dm_comressor_info > */ > struct amdgpu_display_manager { > -- > 2.26.2 > > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel