发件人：Markus Elfring <Markus.Elfring@xxxxxx> 发送日期：2020-04-19 02:18:06 收件人：Bernard Zhao <bernard@xxxxxxxx>,Alex Deucher <alexander.deucher@xxxxxxx>,"Christian König" <christian.koenig@xxxxxxx>,amd-gfx@xxxxxxxxxxxxxxxxxxxxx,dri-devel@xxxxxxxxxxxxxxxxxxxxx 抄送人："Felix Kühling" <Felix.Kuehling@xxxxxxx>,linux-kernel@xxxxxxxxxxxxxxx,opensource.kernel@xxxxxxxx,Chunming Zhou <David1.Zhou@xxxxxxx>,Daniel Vetter <daniel@xxxxxxxx>,David Airlie <airlied@xxxxxxxx> 主题：Re: [PATCH] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond_vms()>> There is no need to if check again, > >Thanks for this information. > >* Should the function name be mentioned in this change description? > >* Would you like to adjust the patch subject? > > >> maybe we could merge into the above else branch. > >I suggest to reconsider this wording. > > >… >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c >> @@ -735,10 +735,8 @@ static int reserve_bo_and_cond_vms(struct kgd_mem *mem, >… > >I propose to take further coding style aspects into account. >https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=90280eaa88ac1a9140dc759941123530d5545bb6#n191 > >Possible refactoring: > if (ret) { > pr_err(…); > … > } else { > ctx->reserved = true; > } > > >How do you think about to add the tag “Fixes”? > Sure, I will modify the code and adjust this patch subject. I will submit it again. >Regards, >Markus _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
