Re:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




发件人:Markus Elfring <Markus.Elfring@xxxxxx>
发送日期:2020-04-19 17:34:47
收件人:Bernard Zhao <bernard@xxxxxxxx>,amd-gfx@xxxxxxxxxxxxxxxxxxxxx,dri-devel@xxxxxxxxxxxxxxxxxxxxx,Alex Deucher <alexander.deucher@xxxxxxx>,"Christian König" <christian.koenig@xxxxxxx>,Chunming Zhou <David1.Zhou@xxxxxxx>
抄送人:Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>,Daniel Vetter <daniel@xxxxxxxx>,David Airlie <airlied@xxxxxxxx>,Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx>,"José Roberto de Souza" <jose.souza@xxxxxxxxx>,Lyude Paul <lyude@xxxxxxxxxx>,Neil Armstrong <narmstrong@xxxxxxxxxxxx>,Sam Ravnborg <sam@xxxxxxxxxxxx>,linux-kernel@xxxxxxxxxxxxxxx,opensource.kernel@xxxxxxxx
主题:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()>> The "if(!encoder)" branch return the same value 0 of the success
>> branch, maybe return -EINVAL is more better.
>
>I suggest to improve the commit message.

Sure.

>
>* Would you like to adjust the patch subject?
>
>* How do you think about to add the tag “Fixes”
>  because of adjustments for the exception handling?

This is a good idea, the code will be more in line with the Linux specifications.
I will adjust this patch commit message and modify the code. I will submit it again.

>
>Regards,
>Markus


_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux