On Thu, Apr 09, 2020 at 10:43:18PM +0530, R Veera Kumar wrote: > It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file > operation rather than DEFINE_SIMPLE_ATTRIBUTE. No, it is not "more clear", the two defines are not the same thing, they do different things. If they were just identical, we would not need them both :) So please be very explicit as to _why_ you want to change this, and show how you have verified that changing this is the correct thing to do, and how you tested. Because the user-visible change can be quite different with this type of kernel change. thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel