Hello, I have taken another look at the implementation of the function “tve200_probe”. A software analysis approach points the following source code out for further development considerations. https://elixir.bootlin.com/linux/v5.6.3/source/drivers/gpu/drm/tve200/tve200_drv.c#L212 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/tve200/tve200_drv.c?id=5d30bcacd91af6874481129797af364a53cd9b46#n212 irq = platform_get_irq(pdev, 0); if (!irq) { ret = -EINVAL; goto clk_disable; } The software documentation is providing the following information for the used programming interface. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/platform.c?id=5d30bcacd91af6874481129797af364a53cd9b46#n221 https://elixir.bootlin.com/linux/v5.6.3/source/drivers/base/platform.c#L202 “… * Return: IRQ number on success, negative error number on failure. …” Would you like to reconsider the shown condition check? Regards, Markus _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
