On Mon, Jan 27, 2020 at 11:40:24AM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Sun, Jan 26, 2020 at 8:44 AM Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Sat, Jan 25, 2020 at 02:55:06PM -0500, Rich Felker wrote: > > > Signed-off-by: Rich Felker <dalias@xxxxxxxx> > > > -- > > > > I know I don't accept patches without any changelog text, don't know > > about other subsystem maintainers... > > FTR, I do, iff the one-line summary says everything that needs to be said. > > What's the point in writing a full paragraph like: > > Currently the foo driver does not support the bar device. > As users may want to use the bar device, it makes perfect sense > to add support for the bar device to the foo driver. > Hence add support for the bar device to the foo driver. > > if this doesn't add any value on top of the one-line summary? At least it allows one to reply to *something*. If there's just a subject line you have zero quoted context for the reply apart from the patch itself. So rather confusing if you want to comment on the overall thing rather than on any specific changes in the diff. The other bad commit message style I dislike is the: "Subject: Do something... ...because whatever." As if the subject was a part of the first sentence of the commit message. Often makes replies even more confusing since now you have just a part of the sentece quoted. I do understand why new people make this mistake though; There should probably be a more explicit indication that the first line is the subject when editing the commit message. -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
