Hi all, Inspired by some chatting with Pekka on irc I looked a lot at our ->fb_create implementations. Some cleanups (the simpler ones) and some todos (the more involved stuff). It's not a lot of code that we can collect even with all the todos, but we have so many drivers nowadays it's worth it even for the tiny things. Review and for the driver patches especially some testing very much welcome. Cheers, Daniel Daniel Vetter (8): drm/fb: More paranoia in addfb checks drm/atmel: ditch fb_create wrapper drm/mediatek: don't open-code drm_gem_fb_create drm/rockchip: Use drm_gem_fb_create_with_dirty drm/tilcdc: Drop drm_gem_fb_create wrapper drm/xen: Simplify fb_create drm/hibmc: Use drm_gem_fb_create drm/todo: Add entry for fb funcs related cleanups Documentation/gpu/todo.rst | 26 ++++++ drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 8 +- drivers/gpu/drm/drm_framebuffer.c | 17 ++-- .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 4 +- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 11 +-- .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 5 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 62 +++---------- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 16 +++- drivers/gpu/drm/mediatek/mtk_drm_fb.c | 92 ------------------- drivers/gpu/drm/mediatek/mtk_drm_fb.h | 13 --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 54 +---------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 8 +- drivers/gpu/drm/xen/xen_drm_front_kms.c | 9 +- 14 files changed, 75 insertions(+), 251 deletions(-) delete mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.c delete mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.h -- 2.24.0 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
