On Fri, 26 Jul 2019, Sam Ravnborg wrote: > Hi Lee. > > On Thu, Jul 25, 2019 at 04:06:29PM +0100, Lee Jones wrote: > > On Thu, 25 Jul 2019, Daniel Vetter wrote: > > > > > On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote: > > > > There was no users left - so drop the code to support EARLY_FB_BLANK. > > > > This patch removes the support in backlight, > > > > and drop the notifier in fbmem. > > > > > > > > That EARLY_FB_BLANK is not used can be verified that no driver set any of: > > > > > > > > lcd_ops.early_set_power() > > > > lcd_ops.r_early_set_power() > > > > > > > > Noticed while browsing backlight code for other reasons. > > > > > > Ah I didn't grep hard enough, I didn't realize that no one sets the > > > lcd_ops->(r_)early_set_power hooks. Nice find! > > > > > > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > > > > > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > > Cc: Lee Jones <lee.jones@xxxxxxxxxx> > > > > Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx> > > > > Cc: Jingoo Han <jingoohan1@xxxxxxxxx> > > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > > > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > > > > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > > > > Cc: "Michał Mirosław" <mirq-linux@xxxxxxxxxxxx> > > > > Cc: Peter Rosin <peda@xxxxxxxxxx> > > > > Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx> > > > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > > > Cc: linux-fbdev@xxxxxxxxxxxxxxx > > > > --- > > > > > > > > Build tested with various architectures, configs. > > > > > > > > Lee, Daniel - OK to commit to drm-misc-next where fbdev stuff is > > > > maintained today? > > > > > > backlight is separate from fbdev in Lee's own tree, not in drm-misc. I > > > think at least. > > > > That's correct. We'll sort that once we have all the Acks. > > We have acks all around now. I am still missing Daniel T's Ack. > OK that I commit this to drm-misc-next? > > This is where we maintain fbdev these days. Or you could apply it to > your backlight tree. > > Both solutins would be fine as the risk of introducing merge conflicts > in these code paths are minimal. If that's the case, then I'd be happy to apply it to the Backlight tree. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
