Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 25 Jul 2019, Daniel Vetter wrote:

> On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote:
> > There was no users left - so drop the code to support EARLY_FB_BLANK.
> > This patch removes the support in backlight,
> > and drop the notifier in fbmem.
> > 
> > That EARLY_FB_BLANK is not used can be verified that no driver set any of:
> > 
> >     lcd_ops.early_set_power()
> >     lcd_ops.r_early_set_power()
> > 
> > Noticed while browsing backlight code for other reasons.
> 
> Ah I didn't grep hard enough, I didn't realize that no one sets the
> lcd_ops->(r_)early_set_power hooks. Nice find!
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> 
> > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> > Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> > Cc: "Michał Mirosław" <mirq-linux@xxxxxxxxxxxx>
> > Cc: Peter Rosin <peda@xxxxxxxxxx>
> > Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > Cc: linux-fbdev@xxxxxxxxxxxxxxx
> > ---
> > 
> > Build tested with various architectures, configs.
> > 
> > Lee, Daniel - OK to commit to drm-misc-next where fbdev stuff is
> > maintained today?
> 
> backlight is separate from fbdev in Lee's own tree, not in drm-misc. I
> think at least.

That's correct.  We'll sort that once we have all the Acks.

> >  drivers/video/backlight/lcd.c    |  8 --------
> >  drivers/video/fbdev/core/fbmem.c | 12 +-----------
> >  include/linux/fb.h               |  4 ----
> >  include/linux/lcd.h              | 10 ----------
> >  4 files changed, 1 insertion(+), 33 deletions(-)

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux