On 2018-04-20 12:53, Russell King - ARM Linux wrote: > On Fri, Apr 20, 2018 at 12:49:42PM +0200, Peter Rosin wrote: >> On 2018-04-20 12:41, kbuild test robot wrote: >>> Hi Peter, >>> >>> I love your patch! Yet something to improve: >> >> Yup, right you are! >> >>> [auto build test ERROR on drm/drm-next] >>> [also build test ERROR on v4.17-rc1 next-20180420] >>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >>> >>> url: https://github.com/0day-ci/linux/commits/Peter-Rosin/Add-tda998x-HDMI-support-to-atmel-hlcdc/20180420-160131 >>> base: git://people.freedesktop.org/~airlied/linux.git drm-next >>> config: i386-randconfig-a0-201815 (attached as .config) >>> compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 >>> reproduce: >>> # save the attached .config to linux build tree >>> make ARCH=i386 >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/gpu/drm/i2c/tda998x_drv.c: In function 'tda998x_probe': >>>>> drivers/gpu/drm/i2c/tda998x_drv.c:1859:16: error: 'struct drm_bridge' has no member named 'of_node' >>> bridge->bridge.of_node = dev->of_node; >>> ^ >> >> Anybody got a better fix than this? >> >> #ifdef CONFIG_OF >> bridge->bridge.of_node = dev->of_node; >> #endif > > How about the bridge code provides a helper to do this, something like: > > static inline void bridge_set_device(struct drm_bridge *bridge, > struct device *dev) > { > #ifdef CONFIG_OF > bridge->of_node = dev->of_node; > #endif > } > > which (a) nicely hides the firmware flavour, and (b) hides the ifdef in > the bridge header where it belongs. If the bridge code needs to be > converted to fwnode in the future, at least this would be abstracted > from the drivers. > Hmm, I looked around and found numerous other #ifdefs for this, so my plan is to just add one more. Fixing up all these ifdefs is orthogonal and can be done later. Cheers, Peter PS. I also noted that I had forgotten to remove a couple of dev_info calls in this patch. Will remove for v4. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
