On Thu, Sep 1, 2016 at 2:08 PM, Christian Gmeiner <christian.gmeiner@xxxxxxxxx> wrote: > Hi Emil, > > thanks a lot for the review. > > 2016-08-30 15:03 GMT+02:00 Emil Velikov <emil.l.velikov@xxxxxxxxx>: >> On 30 August 2016 at 08:14, Christian Gmeiner >> <christian.gmeiner@xxxxxxxxx> wrote: >>> From: The etnaviv authors <dri-devel@xxxxxxxxxxxxxxxxxxxxx> >>> >>> Add the libdrm_etnaviv helper library to encapsulate etnaviv-specific interfaces to the DRM. >>> >>> Signed-off-by: Christian Gmeiner <christian.gmeiner@xxxxxxxxx> >>> Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> >> Just double-checking: >> - you've looked that all the relevant freedreno patches have been >> ported over, correct ? >> - the feature checking bug (mentioned on IRC) has been fixed ? >> >>> diff --git a/configure.ac b/configure.ac >>> index e3048c7..64f3e6c 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >> >>> @@ -274,6 +279,9 @@ if test "x$drm_cv_atomic_primitives" = "xnone"; then >>> >>> LIBDRM_ATOMICS_NOT_FOUND_MSG($TEGRA, tegra, NVIDIA Tegra, tegra-experimental-api) >>> TEGRA=no >>> + >>> + LIBDRM_ATOMICS_NOT_FOUND_MSG($ETNAVIV, etnaviv, Vivante, etnaviv-experimental-api) >> Reading this hunk reminds me what a bad name I've used. Then again >> nothing better comes up atm. If you can think of any please shout. >> >>> +++ b/etnaviv/Android.mk >> Have you tried building/using etna on Android ? >> > > No.. if it is an easy job I would give it a try. Shall I drop it? But I have. libdrm just needs this patch (for master and N): @@ -9,7 +9,7 @@ LOCAL_MODULE_TAGS := optional LOCAL_SHARED_LIBRARIES := libdrm -LOCAL_SRC_FILES := $(LIBDRM_ETNAVIV_FILES) +LOCAL_SRC_FILES := $(patsubst %.h, , $(LIBDRM_ETNAVIV_FILES)) LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH) LOCAL_CFLAGS := \ I've got mesa building on Android, too. It's a few patches so far of Android.mk additions and things that break with clang or post 12.0. The etnaviv branch also breaks other drivers with the max vertex buffer capability addition. Rob _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
