On 1 September 2016 at 20:08, Christian Gmeiner <christian.gmeiner@xxxxxxxxx> wrote: > Hi Emil, > > thanks a lot for the review. > > 2016-08-30 15:03 GMT+02:00 Emil Velikov <emil.l.velikov@xxxxxxxxx>: >> On 30 August 2016 at 08:14, Christian Gmeiner >> <christian.gmeiner@xxxxxxxxx> wrote: >>> From: The etnaviv authors <dri-devel@xxxxxxxxxxxxxxxxxxxxx> >>> >>> Add the libdrm_etnaviv helper library to encapsulate etnaviv-specific interfaces to the DRM. >>> >>> Signed-off-by: Christian Gmeiner <christian.gmeiner@xxxxxxxxx> >>> Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> >> Just double-checking: >> - you've looked that all the relevant freedreno patches have been >> ported over, correct ? >> - the feature checking bug (mentioned on IRC) has been fixed ? >> >>> diff --git a/configure.ac b/configure.ac >>> index e3048c7..64f3e6c 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >> >>> @@ -274,6 +279,9 @@ if test "x$drm_cv_atomic_primitives" = "xnone"; then >>> >>> LIBDRM_ATOMICS_NOT_FOUND_MSG($TEGRA, tegra, NVIDIA Tegra, tegra-experimental-api) >>> TEGRA=no >>> + >>> + LIBDRM_ATOMICS_NOT_FOUND_MSG($ETNAVIV, etnaviv, Vivante, etnaviv-experimental-api) >> Reading this hunk reminds me what a bad name I've used. Then again >> nothing better comes up atm. If you can think of any please shout. >> >>> +++ b/etnaviv/Android.mk >> Have you tried building/using etna on Android ? >> > > No.. if it is an easy job I would give it a try. Shall I drop it? > Mostly curious. It doesn't get in the way so I'd keep it as-is. Everything but the "NB use make headers_install for etnaviv_drm.h" is just polish. So if that's OK you can address any/all of the remainder as small follow up patches on top. It's up-to you really. Since you're likely giving mesa side a final polish before sending, please point out where the latest work can be found in the interim. Thanks Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
