Hi Emil, thanks a lot for the review. 2016-08-30 15:03 GMT+02:00 Emil Velikov <emil.l.velikov@xxxxxxxxx>: > On 30 August 2016 at 08:14, Christian Gmeiner > <christian.gmeiner@xxxxxxxxx> wrote: >> From: The etnaviv authors <dri-devel@xxxxxxxxxxxxxxxxxxxxx> >> >> Add the libdrm_etnaviv helper library to encapsulate etnaviv-specific interfaces to the DRM. >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@xxxxxxxxx> >> Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Just double-checking: > - you've looked that all the relevant freedreno patches have been > ported over, correct ? > - the feature checking bug (mentioned on IRC) has been fixed ? > >> diff --git a/configure.ac b/configure.ac >> index e3048c7..64f3e6c 100644 >> --- a/configure.ac >> +++ b/configure.ac > >> @@ -274,6 +279,9 @@ if test "x$drm_cv_atomic_primitives" = "xnone"; then >> >> LIBDRM_ATOMICS_NOT_FOUND_MSG($TEGRA, tegra, NVIDIA Tegra, tegra-experimental-api) >> TEGRA=no >> + >> + LIBDRM_ATOMICS_NOT_FOUND_MSG($ETNAVIV, etnaviv, Vivante, etnaviv-experimental-api) > Reading this hunk reminds me what a bad name I've used. Then again > nothing better comes up atm. If you can think of any please shout. > >> +++ b/etnaviv/Android.mk > Have you tried building/using etna on Android ? > No.. if it is an easy job I would give it a try. Shall I drop it? > >> +++ b/etnaviv/Makefile.am >> @@ -0,0 +1,27 @@ >> +AUTOMAKE_OPTIONS=subdir-objects > There are no subdirectories so you don't need this. Then again, can we > move the freedreno one to configure.ac - just append to > AM_INIT_AUTOMAKE. > Okay >> +include Makefile.sources >> + >> +AM_CFLAGS = \ >> + $(WARN_CFLAGS) \ >> + -I$(top_srcdir) \ >> + $(PTHREADSTUBS_CFLAGS) \ >> + -I$(top_srcdir)/include/drm >> + >> +libdrm_etnaviv_ladir = $(libdir) >> +libdrm_etnaviv_la_LTLIBRARIES = libdrm_etnaviv.la >> +libdrm_etnaviv_la_LDFLAGS = -version-number 0:0:0 -no-undefined > Maybe make this 1:0:0 ? > Sure.. why not. >> --- /dev/null >> +++ b/etnaviv/etnaviv-symbol-check >> @@ -0,0 +1,45 @@ >> +#!/bin/bash >> + >> +# The following symbols (past the first five) are taken from the public headers. >> +# A list of the latter should be available Makefile.sources/LIBDRM_FREEDRENO_H_FILES >> + > LIBDRM_ETNAVIV_H_FILES? > Opps... good catch. Will fix it in v2. > >> new file mode 100644 >> index 0000000..462241c >> --- /dev/null >> +++ b/etnaviv/etnaviv_drm.h > Double-checking: this file is identical to the one produced by make > headers_install, correct ? > I need to check that - if something is wrong it will be fixed in v2. greets -- Christian Gmeiner, MSc https://soundcloud.com/christian-gmeiner _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
