The LCDC in its simplicity does not fit too well into DRM atomic modeset abstractions. I wonder if I am doing the right thing in implementing the dummy primary plane and in implementing mode_set_nofb() crtc helper when the crtc actually needs the framebuffer to be there when configuring it. See individual patch descriptions for details. There is still lot of room for cleaning up but I would first like to know if I am moving at all to the right direction. Jyri Sarha (11): drm/tilcdc: Make tilcdc_crtc_page_flip() public drm/tilcdc: Add dummy primary plane implementation drm/tilcdc: Initialize dummy primary plane from crtc init drm/tilcdc: Add tilcdc_crtc_mode_set_nofb() drm/tilcdc: Add tilcdc_crtc_atomic_check() drm/tilcdc: Add atomic mode config funcs drm/tilcdc: Add drm_mode_config_reset() call to tilcdc_load() drm/tilcdc: Call drm_crtc_vblank_off() in tilcdc_crtc_destroy() drm/tilcdc: Set DRIVER_ATOMIC and use atomic crtc helpers drm/tilcdc: Remove obsolete crtc helper functions drm/tilcdc: Remove tilcdc_verify_fb() drivers/gpu/drm/tilcdc/Makefile | 1 + drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 142 +++++++++++++++------------------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 52 ++++++++++++- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 6 ++ drivers/gpu/drm/tilcdc/tilcdc_plane.c | 122 +++++++++++++++++++++++++++++ 5 files changed, 244 insertions(+), 79 deletions(-) create mode 100644 drivers/gpu/drm/tilcdc/tilcdc_plane.c -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel