On 19/01/2019 16:21, Andy Shevchenko wrote: > On Wed, Jan 16, 2019 at 11:53:00AM +0000, Gustavo Pimentel wrote: >> On 16/01/2019 10:21, Jose Abreu wrote: >>> On 1/11/2019 6:33 PM, Gustavo Pimentel wrote: > >>>> + /* Free irqs */ >>> >>> But devm will automatically free it, no ? >> >> Yes, it shouldn't be there. I'll remove it. > > It depends. If the driver is using tasklets it must free it explicitly like this. In this driver I'm not using tasklets. > > P.S. devm_*_irq() is quite doubtful to have in the first place. For curiosity, why? > >
