On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > Hi Soren, > > >> -----Original Message----- >> From: Sören Brinkmann [mailto:soren.brinkmann@xxxxxxxxxx] >> Sent: Wednesday, April 06, 2016 9:50 PM >> To: Appana Durga Kedareswara Rao <appanad@xxxxxxxxxx> >> Cc: robh+dt@xxxxxxxxxx; pawel.moll@xxxxxxx; mark.rutland@xxxxxxx; >> ijc+devicetree@xxxxxxxxxxxxxx; galak@xxxxxxxxxxxxxx; Michal Simek >> <michals@xxxxxxxxxx>; vinod.koul@xxxxxxxxx; dan.j.williams@xxxxxxxxx; >> Appana Durga Kedareswara Rao <appanad@xxxxxxxxxx>; >> moritz.fischer@xxxxxxxxx; laurent.pinchart@xxxxxxxxxxxxxxxx; >> luis@xxxxxxxxxxxxxxxxx; Srikanth Vemula <svemula@xxxxxxxxxx>; Anirudha >> Sarangi <anirudh@xxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> dmaengine@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan >> prefix to dma-chan >> >> On Wed, 2016-04-06 at 21:45:31 +0530, Kedareswara rao Appana wrote: >>> This patch renames the vdma-mm2s-channel/vdma-s2mm-channel >>> property with dma-mm2s-channel/dma-s2mm-channel to sync with the >>> driver. >>> >>> Signed-off-by: Kedareswara rao Appana <appanad@xxxxxxxxxx> >>> --- >>> Changes for v3: >>> ---> New patch. >>> >>> Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 8 >>> ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt >>> b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt >>> index a86737c..762938f 100644 >>> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt >>> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt >>> @@ -24,8 +24,8 @@ Optional properties: >>> {3}, flush s2mm channel >>> >>> Required child node properties: >>> -- compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or >>> - "xlnx,axi-vdma-s2mm-channel". >>> +- compatible: It should be either "xlnx,axi-dma-mm2s-channel" or >>> + "xlnx,axi-dma-s2mm-channel". >> >> This change is not backwards compatible and breaks every user of the current >> binding. > > This commit http://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-dma.git/commit/?h=next&id=8e66e7d682b04f7141f8ae666908c8dcd7fc0bfa > Renames xilinx_vdma_ prefix to xilinx_dma which includes renaming of the above properties. > The patch (dmaengine: vdma: Rename xilinx_vdma_ prefix to xilinx_dma) already got applied in the dma-next tree. > That's why sent this patch to sync with the current driver I mean latest driver. The correct solution for this is to revert that part of the change ASAP, since, as Soeren pointed out, it breaks all existing users. Thanks, - Lars -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
