Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote:
> On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote:
> > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > +++
> > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > @@ -24,8 +24,8 @@ Optional properties:
> > > >  	{3}, flush s2mm channel
> > > > 
> > > >  Required child node properties:
> > > > -- compatible: It should be either "xlnx,axi-vdma-mm2s-channel"
> > > > or
> > > > -	"xlnx,axi-vdma-s2mm-channel".
> > > > +- compatible: It should be either "xlnx,axi-dma-mm2s-channel"
> > > > or
> > > > +	"xlnx,axi-dma-s2mm-channel".
> > > 
> > > This change is not backwards compatible and breaks every user of
> > > the current
> > > binding.
> > 
> > This commit http://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-
> > dma.git/commit/?h=next&id=8e66e7d682b04f7141f8ae666908c8dcd7fc0bfa 
> > Renames xilinx_vdma_ prefix to xilinx_dma which includes renaming of
> > the above properties.

That patch changes driver from vdma to dma. It does not change property
name!

> > The patch (dmaengine: vdma: Rename xilinx_vdma_ prefix to
> > xilinx_dma) already got applied in the dma-next tree.
> > That's why sent this patch to sync with the current driver I mean
> > latest driver.
> 
> The correct solution for this is to revert that part of the change
> ASAP,
> since, as Soeren pointed out, it breaks all existing users.

No the commit applied is only the name changes inside the driver. They
don't break anything yet. IIUC this patch breaks not the applied one..

Thanks
-- 
~Vinod
��.n��������+%������w��{.n��������)�)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux